Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide completion proposals for variables in launch.json #8370

Closed
aeschli opened this issue Jun 28, 2016 · 4 comments
Closed

Provide completion proposals for variables in launch.json #8370

aeschli opened this issue Jun 28, 2016 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues tasks Task system issues verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jun 28, 2016

It would be great of there are completion proposals for variables in launch.json.
That's now quite easy to add, check out https://github.com/Microsoft/vscode/blob/master/extensions/configuration-editing/src/extension.ts.
This adds completions to keybindings.json.

You could add yourself also to the 'configuration-editing' extension, as launch is also a configuration file.

@isidorn isidorn added this to the July 2016 milestone Jun 28, 2016
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Jun 28, 2016
@isidorn
Copy link
Contributor

isidorn commented Jul 6, 2016

Thanks for the code pointer. However each debug adapter extension provides these variables, so I can not just add a list of these in the configuration editing extension. The right solution for me feels like each debug adapter extension would provide these completion proposal.

VSCode could also dynamically provide this list of proposols after collecting them from the adapter extensions however in vscode I can not get a reference to your json-parser, I only see it being used from extensions (thus I can not read the location).

Assigning also @weinand

@aeschli
Copy link
Contributor Author

aeschli commented Jul 6, 2016

@isidorn The vscode.d.ts API lets you get all extensions (extensions.getExtension), so you can actually find out about all contributed variables.
If you wanted to do this in the main process you can use vs/base/common/json. But I don't recommend that as we should not do too much parsing the main thread. Doing it in the 'configuration-editing' extension seems like the right place to do.
Doing it in every debug adapter extension is also possible, but it would mean that every extension would parse the file instead of just doing it at one place.

@isidorn
Copy link
Contributor

isidorn commented May 9, 2018

We now suggest variables inside values that are string for both the tasks.json and launch.json

@dbaeumer let me know if you do not like this behavior for tasks.json and I can disable it, though I find it very nice.

screen shot 2018-05-09 at 16 31 30

@dbaeumer
Copy link
Member

@isidorn like it as well. Thanks for working on it.

@isidorn isidorn added the verification-needed Verification of issue is requested label May 15, 2018
@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels May 30, 2018
@isidorn isidorn added the release-notes Release notes issues label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants