Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] In product release notes are ugly compared to desktop #83701

Closed
mjbvz opened this issue Oct 30, 2019 · 1 comment
Closed

[Web] In product release notes are ugly compared to desktop #83701

mjbvz opened this issue Oct 30, 2019 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web webview Webview issues
Milestone
October 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 30, 2019

Repo

  1. Using web
  2. Open in product release notes

Bug
Left is web, right is electron

Screen Shot 2019-10-30 at 3 35 32 PM

  • Different font
  • Cramped line spacing
  • No block quote styling
@mjbvz mjbvz added webview Webview issues web Issues related to running VSCode in the web labels Oct 30, 2019
@mjbvz mjbvz self-assigned this Oct 30, 2019
@mjbvz
Copy link
Contributor Author

mjbvz commented Oct 30, 2019

This is because release note css doesn't get loaded at all:

http://localhost:9888/static/out/vs/workbench/contrib/update/browser/media/markdown.css

We should inline the css like we did for our extension pages

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 30, 2019
@mjbvz mjbvz added this to the October 2019 milestone Oct 30, 2019
@mjbvz mjbvz closed this as completed in 44d880e Oct 30, 2019
@alexr00 alexr00 added the verified Verification succeeded label Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web webview Webview issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
2 participants
@mjbvz @alexr00