Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer icons show up briefly when resizing down #83726

Closed
Tyriar opened this issue Oct 31, 2019 · 3 comments
Closed

Explorer icons show up briefly when resizing down #83726

Tyriar opened this issue Oct 31, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues ux User experience issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 31, 2019

icons

Version: 1.40.0-insider (user setup)
Commit: 31f577e
Date: 2019-10-30T05:39:27.063Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

@miguelsolorio
Copy link
Contributor

Interesting, I think this is happening because the mouse is extending into the explorer area, causing it to trigger a hover event for the explorer (which shows the icons). @isidorn, we should probably set a condition to not show when a drag event is happening.

@isidorn
Copy link
Contributor

isidorn commented Nov 12, 2019

This is not explorer specific but happens with all split views.
Forwarding to @sandy081

And yes @misolori you are probably right, the mouse goes over the view triggerin the css rule to show the action in the action bar on hover.

@isidorn isidorn assigned sandy081 and unassigned isidorn and miguelsolorio Nov 12, 2019
@sandy081 sandy081 assigned joaomoreno and unassigned sandy081 Nov 13, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues ux User experience issues labels Nov 13, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 13, 2019
@joaomoreno
Copy link
Member

This applies to any hoverable element inside each splitview view: explorer action bars, debug breakpoint markers, line hovers, editor hovers, etc.

I've pushed a change which sets pointer-events: none in splitview views during sash resizes. cc @bpasero @sbatten for awareness, since it also affects the grid.

@Tyriar Tyriar added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants