Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Disable standard browser select all in settings editor #83850

Closed
mjbvz opened this issue Nov 1, 2019 · 4 comments
Closed

[Web] Disable standard browser select all in settings editor #83850

mjbvz opened this issue Nov 1, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 1, 2019

Repo

  1. On web
  2. Go to settings editor and make sure it is focused
  3. Use the browser/os select all keyboard shortcut (cmd+a)

Bug
All text on the page is selected

Screen Shot 2019-11-01 at 11 18 33 AM

@roblourens
Copy link
Member

Can I disable "select all" without disabling text selection? I want names and descriptions to be select/copyable.

@roblourens roblourens added the info-needed Issue requires more information from poster label Nov 3, 2019
@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 4, 2019

In the editor, don't we intercept the cmd+a keyboard event and call preventDefault if required?

@vscodebot vscodebot bot closed this as completed Nov 11, 2019
@vscodebot
Copy link

vscodebot bot commented Nov 11, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@mjbvz mjbvz removed the info-needed Issue requires more information from poster label Nov 11, 2019
@mjbvz mjbvz reopened this Nov 11, 2019
@roblourens
Copy link
Member

roblourens commented Nov 12, 2019

In desktop, I get this when pressing cmd+a on the settings page

[renderer1] [trace] CommandService#executeCommand editor.action.selectAll
[renderer1] [trace] telemetry/commandExecuted {"id":"editor.action.selectAll","from":"menu"}

which is weird, I think this actually comes from electron.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Nov 12, 2019
@roblourens roblourens added this to the November 2019 milestone Nov 12, 2019
@mjbvz mjbvz added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants