Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: make extHostSearch not depend on node #84106

Closed
bpasero opened this issue Nov 7, 2019 · 1 comment
Closed

Search: make extHostSearch not depend on node #84106

bpasero opened this issue Nov 7, 2019 · 1 comment
Assignees
@roblourens @bpasero
Labels
api debt Code quality issues
Milestone
November 2019

Comments

@bpasero
Copy link
Member

bpasero commented Nov 7, 2019

We need to move extHostSearch into a common layer so that it can run in our web-worker extension host. I see no real reason why we cannot move it, I think the node-specific dependencies should be moved to a node layer from where they register themselves to the search service.
@bpasero bpasero added api debt Code quality issues labels Nov 7, 2019
bpasero added a commit that referenced this issue Nov 7, 2019
@bpasero
debt - move fileSearchManager to common (for #84106)
f692972
@bpasero bpasero self-assigned this Nov 7, 2019
@bpasero bpasero added this to the November 2019 milestone Nov 7, 2019
@bpasero bpasero closed this as completed Nov 13, 2019
@bpasero
Copy link
Member Author

bpasero commented Nov 13, 2019

via #84109

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@bpasero bpasero

Labels
api debt Code quality issues
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
2 participants
@roblourens @bpasero