Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: trusted domain dialog does not persist my choice #84215

Closed
bpasero opened this issue Nov 8, 2019 · 4 comments
Closed

Web: trusted domain dialog does not persist my choice #84215

bpasero opened this issue Nov 8, 2019 · 4 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web workbench-link Link protection in workbench
Milestone
November 2019

Comments

@bpasero
Copy link
Member

bpasero commented Nov 8, 2019

Steps to Reproduce:

  1. selfhost web
  2. open package.json
  3. hover over a package
  4. click on a link
  5. configure links to open all
  6. click again

=> 馃悰 dialog still shows

image

Btw I think after I configured the trusted links, I would expect the link to open right after.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug web Issues related to running VSCode in the web labels Nov 8, 2019
@octref
Copy link
Contributor

octref commented Nov 8, 2019

@sbatten Seems to be caused by your changes

@octref octref added the workbench-link Link protection in workbench label Nov 8, 2019
@octref octref added this to the November 2019 milestone Nov 8, 2019
@sbatten
Copy link
Member

sbatten commented Nov 8, 2019

@octref why would my change have anything to do with this? Mine is just display logic. This reproduces with or without my commit.

@sbatten sbatten removed their assignment Nov 8, 2019
@sbatten
Copy link
Member

sbatten commented Nov 8, 2019

@octref this only reproduces in OSS if you populate linkProtectionTrustedDomains

@octref
Copy link
Contributor

octref commented Nov 9, 2019

Sorry for wrong diagnosis. The root cause is I used UInt8Array.toString on web whereas I should have used VSBuffer.wrap(arr).toString, which would use the TextEncoder as Buffer doesn't exist on web.

@octref octref closed this as completed in 696465b Nov 9, 2019
@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded web Issues related to running VSCode in the web workbench-link Link protection in workbench
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
4 participants
@bpasero @RMacfarlane @octref @sbatten