Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent icon theme colors #85182

Closed
yzhang-gh opened this issue Nov 20, 2019 · 2 comments
Closed

Inconsistent icon theme colors #85182

yzhang-gh opened this issue Nov 20, 2019 · 2 comments
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2020

Comments

@yzhang-gh
Copy link
Contributor

  • VSCode Version: 1.40.1
  • OS Version: Windows 10

Install and use Material Theme. It doesn't look like an issue solely caused by the theme extension.

(All buttons below are enabled except for those with caption "button disabled")

SCM
image

Search
image

Search (button disabled)
image

Extensions
image

Extensions (button disabled)
image

cc @misolori
@miguelsolorio
Copy link
Contributor

miguelsolorio commented Nov 20, 2019 •
edited

For the SCM icons, those are due to our built-in extensions not using our icon font, which isn’t supported yet but is on deck next.

I’ll look into the icons for the extension & search viewlet.

@miguelsolorio miguelsolorio added icons-product Issues for in-product icons bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Nov 20, 2019
@miguelsolorio miguelsolorio added this to the Backlog milestone Nov 20, 2019
@eamodio eamodio mentioned this issue Feb 16, 2020
Closed
@miguelsolorio
Copy link
Contributor

miguelsolorio commented Oct 6, 2020 •
edited

Explorer

Search

SCM

Debug

Extensions

@miguelsolorio miguelsolorio modified the milestones: Backlog, October 2020 Oct 6, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Oct 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions icons-product Issues for in-product icons insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2020
Development

No branches or pull requests
4 participants
@RMacfarlane @yzhang-gh @miguelsolorio and others