Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoke test: "verifies that 'Go To Definition' works" fails #85276

Closed
alexr00 opened this issue Nov 21, 2019 · 2 comments
Closed

smoke test: "verifies that 'Go To Definition' works" fails #85276

alexr00 opened this issue Nov 21, 2019 · 2 comments
Assignees
@joaomoreno @jrieken @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug smoke-test-failure verified Verification succeeded
Milestone
November 2019

Comments

@alexr00
Copy link
Member

alexr00 commented Nov 21, 2019

It looks like the title of a command might have changed ("Go to Implementation" -> "Go to Implementations").
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug smoke-test-failure labels Nov 21, 2019
@alexr00 alexr00 added this to the November 2019 milestone Nov 21, 2019
@alexr00
Copy link
Member Author

alexr00 commented Nov 21, 2019

Fix was to add an s so I just pushed it.

@jrieken
Copy link
Member

jrieken commented Nov 21, 2019

Thanks

@roblourens roblourens added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@alexr00
Fix Go To Definition smoketest
6fc8668 
Fixes microsoft#85276
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@jrieken jrieken

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug smoke-test-failure verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @jrieken @alexr00