New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension View's publisher have greyscale rendering #86192
Comments
If you know the background color precisely you can compute the opacity by blending colors together and thus avoid opacity which is likely causing the issue in this case. Example:
|
I am using opacity in both the cases
@bpasero Do you suggest to use above computation instead of setting css opacity ? If so can you help me in understanding which colours to use for bending. |
Yes I think #86192 (comment) is still a good solution, but you might need to be aware of wether your view is inside sidebar or panel now. |
I am sorry if my question does not make sense - these are rendered inside the list widget and are you saying that every time I have to use opacity I have to do this computation? I am assuming the list / tree widget takes care of this grey scale rendering and the elements inside it does not need to, is not it @joaomoreno ? |
As far as I remember, any element with |
Not sure I understood the question. The tree/list doesn't prevent you from having subpixel AA. But it also doesn't guarantee it for its users, since there are things done on row content, eg opacity, which could prevent it. |
Used the trick @bpasero suggested and it worked |
Here are the layers rendered (which I got with the help of @joaomoreno) As from @joaomoreno @bpasero @deepak1556 any idea if this is an electron issue and if not shall we have to follow this blending trick at all such places? |
@sandy081 we have had a lot of discussion with the Chrome team in the past and I think Alex made a good list of conditions under which Chrome may decide to switch to greyscale rendering (https://bugs.chromium.org/p/chromium/issues/detail?id=1016062#c31). I doubt it is Electron to blame, rather Chrome, but then again unlikely to get a fix imho. As for As you can see, some of these issues are still open or closed "as designed", simply because the technical solution was not straight forward. tl;dr;: we try our best to get LCD rendering, but by no means are we thinking that we get to 100%. Just to give an example: notification toasts do not render with LCD rendering because of many factors, such as animations, border shadow, etc. I did not have the energy to make it work there. Ah, and btw other browsers are fine, Firefox always renders in LCD, no matter what. And this is even platform specific, e.g. I was not able to see this issue on Windows, only Linux. |
This can be verified only on Linux.
|
I had a bit of trouble with this until I realized the best way is to take a screenshot and then zoom in, not the other way around. Verified! |
Ref #85143
Version: 1.41.0-insider
Commit: 9785578
Date: 2019-12-03T05:31:49.954Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 4.15.0-55-generic
The text was updated successfully, but these errors were encountered: