Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update path library to be in sync with node #87092

Closed
bpasero opened this issue Dec 16, 2019 · 1 comment
Closed

Update path library to be in sync with node #87092

bpasero opened this issue Dec 16, 2019 · 1 comment
Assignees
@sbatten
Labels
debt Code quality issues
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Dec 16, 2019

I think we should ensure that our copy of the vs/base/path library stays in sync with the Electron version we use to avoid weird issues when using path in core vs extensions.

The version matching our node is: https://github.com/nodejs/node/blob/v12.4.0/lib/path.js
@bpasero bpasero added the debt Code quality issues label Dec 16, 2019
@sbatten sbatten added this to the On Deck milestone Dec 16, 2019
@sbatten sbatten modified the milestones: On Deck, March 2020 Mar 3, 2020
@sbatten sbatten closed this as completed in 56d182f Mar 3, 2020
@sbatten
Copy link
Member

sbatten commented Mar 3, 2020

I updated to 12.8.1 which I see as the latest in OSS build

@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @sbatten