Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emmet uses workspace.rootPath #87493

Closed
roblourens opened this issue Dec 21, 2019 · 2 comments
Closed

emmet uses workspace.rootPath #87493

roblourens opened this issue Dec 21, 2019 · 2 comments
Assignees
@octref
Labels
debt Code quality issues
Milestone
March 2020

Comments

@roblourens
Copy link
Member

vscode/extensions/emmet/src/util.ts

Line 35 in c0c4eb6

_emmetHelper.updateExtensionsPath(extensionsPath, vscode.workspace.rootPath).then(null, (err: string) => vscode.window.showErrorMessage(err));

@roblourens roblourens added the debt Code quality issues label Dec 21, 2019
@octref octref added this to the January 2020 milestone Dec 21, 2019
@octref octref modified the milestones: January 2020, February 2020 Jan 30, 2020
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 26, 2020
Closed
3 tasks
@octref octref modified the milestones: February 2020, March 2020 Feb 26, 2020
@octref octref added *duplicate Issue identified as a duplicate of another issue(s) and removed debt Code quality issues labels Feb 26, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 26, 2020

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 26, 2020
@octref
Copy link
Contributor

octref commented Feb 26, 2020

Tracked in #90562.

@octref octref reopened this Feb 26, 2020
@octref octref added debt Code quality issues and removed *duplicate Issue identified as a duplicate of another issue(s) labels Feb 26, 2020
@octref octref closed this as completed in ea2f6c6 Mar 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@roblourens @octref