Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File drag and drop does not open the Explorer pane. #87596

Closed
panoschal opened this issue Dec 23, 2019 · 4 comments · Fixed by #88078
Closed

File drag and drop does not open the Explorer pane. #87596

panoschal opened this issue Dec 23, 2019 · 4 comments · Fixed by #88078
Assignees
@isidorn @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues regression Something that used to work is now broken verified Verification succeeded
Milestone
January 2020

Comments

@panoschal
Copy link

panoschal commented Dec 23, 2019 •
edited

  • VSCode Version: 1.41.1
  • OS Version: Windows 10

Steps to Reproduce:

  1. Minimize the "Explorer" view (e.g. with Ctrl+B)
  2. Drag a file from the Windows Explorer
  3. Try to drop it in the Explorer icon in vscode.
  4. The explorer does not automatically open, which would be somewhat helpful, in order to be able to drop the file in the folder of your choice directly.

Does this issue occur when all extensions are disabled?: Yes
@isidorn
Copy link
Contributor

isidorn commented Dec 23, 2019

This is a fair feature request for the compositeBar that on dragOver the corresponding view would get open.
I think this feature reuqest makes sense in general, since in the future we might want to drag and drop views between containers, and then the corresponding container should expand.
Thus also assigning to @sbatten

@isidorn isidorn added this to the Backlog milestone Dec 23, 2019
@isidorn isidorn added feature-request Request for new features or functionality layout General VS Code workbench layout issues labels Dec 23, 2019
@bpasero
Copy link
Member

bpasero commented Dec 27, 2019 •
edited

@isidorn @sbatten this is a regression though. Testing 1.39 I can move a file from the desktop over the (collapsed) activity bar and views expand properly and focus depending on which view is hovered. This was very useful to drag images to vscode-docs for writing release notes. Can we bring it back?

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken and removed feature-request Request for new features or functionality labels Dec 27, 2019
@isidorn isidorn modified the milestones: Backlog, January 2020 Dec 27, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 27, 2019 •
edited

Re-labeled it then, and assigned to Janaury so we try to fix it this milestone. @sbatten hope that makes sense.

jeanp413 added a commit to jeanp413/vscode that referenced this issue Jan 4, 2020
@jeanp413
Fixes microsoft#87596
f99bc0c
@jeanp413 jeanp413 mentioned this issue Jan 4, 2020
Merged
@isidorn
Copy link
Contributor

isidorn commented Jan 6, 2020

Thanks a lot for the fix @jeanp413

@RMacfarlane RMacfarlane added the verified Verification succeeded label Jan 29, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
January 2020
Development

Successfully merging a pull request may close this issue.

Fixes file drag and drop does not open the explorer pane jeanp413/vscode
5 participants
@bpasero @isidorn @RMacfarlane @sbatten @panoschal