Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breakers from code/electron-main to vs/workbench #8809

Closed
bpasero opened this issue Jul 6, 2016 · 3 comments
Closed

Layer breakers from code/electron-main to vs/workbench #8809

bpasero opened this issue Jul 6, 2016 · 3 comments
Assignees
@joaomoreno
Labels
debt Code quality issues git GIT issues
Milestone
May 2017

Comments

@bpasero
Copy link
Member

bpasero commented Jul 6, 2016 •
edited

Some issues:

  • there are dependencies into vs/workbench from vs/code
  • vs/code/main has knowledge about git for the askpass and reaches into vs/workbench/part/git (this probably asks for some kind of registry to contribute)
@bpasero bpasero added debt Code quality issues git GIT issues labels Jul 6, 2016
@joaomoreno joaomoreno added this to the Backlog milestone Jul 6, 2016
@bpasero bpasero self-assigned this Jul 6, 2016
@bpasero bpasero changed the title Move git/electron-main into code/electron-main Layer breakers from code/electron-main to vs/workbench Jul 6, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 5, 2016

We got rid of userSettings, so only git remains.

@bpasero bpasero removed their assignment Sep 5, 2016
@bpasero
Copy link
Member Author

bpasero commented Apr 4, 2017

@joaomoreno is the new SCM provider still using AskpassChannel and GitAskpassService?

@joaomoreno
Copy link
Member

@bpasero I still haven't removed Git. People can still go back to it. Let's remove it this week. #24014

@joaomoreno joaomoreno modified the milestones: May 2017, Backlog Apr 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
debt Code quality issues git GIT issues
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
2 participants
@joaomoreno @bpasero