@deepak1556 looks like this was fixed originally by an electron update, something regress here?

Just wanted to update that the latest update still has this issue. --force srgb still works but had to reimplement it.

Seems like a regression from upstream chromium, will have to wait for a fix from them. https://bugs.chromium.org/p/chromium/issues/detail?id=1038770

If we cannot get a fix, we should make sure force-color-profile is a supported option for argv.json (https://github.com/microsoft/vscode/blob/3aa5383/src/main.js#L128)

If we cannot get a fix, we should make sure force-color-profile is a supported option for argv.json (https://github.com/microsoft/vscode/blob/3aa5383/src/main.js#L128)

I second this. I love that you guys are updating and working on this amazing free software, but it's admittedly annoying and inconvenient to have to keep putting this in. At the very least, stop re-creating the shortcut after updates?

@AzureWolf can we try out something:

• close any running instance of VSCode
• download https://az764295.vo.msecnd.net/insider/7428f161b0def9c82f5582b977f837fb0ad63453/VSCode-win32-x64-1.42.0-insider.zip and unzip and run
• quick open command palette and pick "Configure Runtime Arguments"
• replace the file with the contents below [1] (ignore the warning)
• close
• start same version again

I am trying to figure out if the --force-color-profile srgb works when passed in programmatically so that you do not have to specify it each time from the command line.

[1]

{
	"disable-color-correct-rendering": true,
	"force-color-profile": "srgb"
}

Hey sorry I just saw this. The issue seems to have been resolved. I also tested what you asked @bpasero and it doesn't appear to work (tested by following your instructions, that version is still dark, and running and re-running does not resolve it).

So it seems like it's resolved and hopefully won't be an issue? I don't know what changed.

@AzureWolf we reverted to electron 6 in master, so its temporarily fixed in the insiders, but based on the original issue it should reappear once we get electron 7 update again. The chromium issue is still open but I will backport a potential fix the chromium authors mentioned. I can get a custom build some time today or tomorrow, would be great if you can test that.

Sure happy to help!

@AzureWolf ok let's try that experiment again if you can. There is a newer build available [1]

• close any running instance of VSCode
• download [1]
• quick open command palette and pick "Configure Runtime Arguments"
• replace the file with the contents below [2]
• close
• start same version again

=> are the colors better?

[1] https://az764295.vo.msecnd.net/insider/a1f569c66f67287c525ee50b5f46ced8a50b4551/VSCode-darwin-insider.zip

[2]

{
	"disable-color-correct-rendering": true,
	"force-color-profile": "srgb"
}

@AzureWolf ping

I pushed support for configuring the color profile via our runtime arguments file. Steps to enable this:

• use command palette to find runtime arguments command [1]
• add "force-color-profile": "srgb" to the end of the file
• restart

[1]

Hey super sorry. I'll check it out when I get a chance. For now I just removed HDR from my monitor settings so I have to set that up again when I'm not busy. It was a real pain to see a daily loss of brightness at the start of the day and it's been busy. I'll let you know.

Very sorry about that

Hey just tested this out and it does and doesn't work. So putting "disable-color-correct-rendering" to false fixes the issue. Setting it to true does not resolve the issue. Setting it to true and adding the color profile (as the screenshot you see here) does not fix the issue.

Thank you so much for this! I can finally go back to using HDR on my monitor! I don't know what it is, but it doesn't really make a big difference but all the colors are "softer" or less intense except where appropriate. It's hard to describe, but it makes it easier to work longer, so I'm super grateful. I'll be sure to thank you guys wherever possible. You guys are an amazing team making an exceptional and free product.

EDIT: may be a stupid question, but the other application I'm experiencing this issue on was mpv (the video player). Any chance you know what would be the equivalent setting there?

@AzureWolf thanks for giving this a try. Since you see yellow squigglies in the editor I wonder if you maybe tried with VSCode stable and not insiders? Can you recheck this with our insiders build?

You can give our preview releases a try from: https://code.visualstudio.com/insiders/

You should not see a yellow warning like that which indicates that this property is not being applied.

I'm using Insiders:
Version: 1.43.0-insider (user setup)
Commit: 07c3397
Date: 2020-02-24T05:33:18.353Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

Just to note that this is still an issue in 1.46.1

You can see the contrast difference (and the bizarre random white box) between the VS Code window and a normal Windows UI window it's sitting on top of ..

The issue should be fixed in latest insiders https://code.visualstudio.com/insiders/, please verify by removing any workarounds added via argv.json

@deepak1556 Verified fixed in Insiders. Thanks!

Still exists for me with the insiders version, as long as i have vs code windowed it works, but as soon as i go to fullscreen the screen dims.

Sorry about that, we have reverted the runtime which contains the fix for this iteration. The fix will be available again from next week once we update to Electron 9 in master.

Hi this is still broken for me

Not sure if it can be seen but most of the screen is dim except for a couple of blocks where there is no text

For what it's worth, other electron apps that I use don't have these problems

I edited my runtime args disable-color-correct-rendering to false and now things work. Granted, I have no idea if it is "correct".

Both of my screens (internal laptop 4k OLED w/ HDR and external 4k LCD no HDR) support DCI P3. Would like to make sure my colors are correct.

The upstream fix will be available with upcoming stable release and is already available with current insiders, please check. Thanks!

Putting "force-color-profile": "srgb" in argv.json fixed it for me

(Samsung G9 HDR full brightness)

This has finally been fixed in 1.49.1 with Electron 9.2.1