Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.warn in unit tests #88672

Closed
bpasero opened this issue Jan 15, 2020 · 1 comment
Closed

console.warn in unit tests #88672

bpasero opened this issue Jan 15, 2020 · 1 comment
Assignees
@sandy081
Labels
debt Code quality issues unit-test-failure
Milestone
January 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jan 15, 2020

Steps to Reproduce:

  1. run our unit tests
  2. notice the following output:

[1040:0115/125822.998550:INFO:CONSOLE(174)] "Cannot register 'a'. This property is already registered.", source: file:///home/bpasero/development/monaco/out/vs/platform/configuration/common/configurationRegistry.js (174)

I am not sure if we should simply remove the console.warn usage here.
@bpasero bpasero mentioned this issue Jan 15, 2020
Closed
@sandy081 sandy081 added the debt Code quality issues label Jan 15, 2020
@sandy081 sandy081 added this to the January 2020 milestone Jan 15, 2020
@sandy081
Copy link
Member

Removed console.warn as the extension contributions are validated already.

sandy081 added a commit that referenced this issue Jan 15, 2020
@sandy081
Revert "Fix #88672"
58696e9 
This reverts commit 9002477.
@sandy081 sandy081 reopened this Jan 15, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues unit-test-failure
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
2 participants
@bpasero @sandy081