Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search editor: onDidChangeContent is not properly implemented #89265

Closed
bpasero opened this issue Jan 25, 2020 · 1 comment
Closed

Search editor: onDidChangeContent is not properly implemented #89265

bpasero opened this issue Jan 25, 2020 · 1 comment
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug search-editor

Comments

@bpasero
Copy link
Member

bpasero commented Jan 25, 2020

This line seems fishy:

vscode/src/vs/workbench/contrib/search/browser/searchEditorInput.ts

Line 78 in 3a1e245

onDidChangeContent: this.onDidChangeDirty,

You need to connect to the text model you resolve and re-emit the text content change events from that model.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug search-editor labels Jan 25, 2020
@bpasero bpasero assigned connor4312 and JacksonKearl and unassigned connor4312 Jan 25, 2020
@JacksonKearl JacksonKearl changed the title Search editor: onDidSearchContent is not properly implemented Search editor: onDidChangeContent is not properly implemented Jan 25, 2020
@bpasero
Copy link
Member Author

bpasero commented Jan 26, 2020

This probably becomes obsolete when #89268 is resolved.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug search-editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @connor4312 @JacksonKearl