Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show breakpoint window without creating a launch.json in the workplace folder #89290

Closed
xubury opened this issue Jan 26, 2020 · 6 comments
Closed

Show breakpoint window without creating a launch.json in the workplace folder #89290

xubury opened this issue Jan 26, 2020 · 6 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2020

Comments

@xubury
Copy link

xubury commented Jan 26, 2020

After recent update, the debug tab no longer shows the breakpoint window until you create a launch.json. Personally I find that annoying cause I use the cmake-tool extension which allows me to debug without launch.json. Now, I have to create a launch.json to check the breakpoints before debug which seems so unnecessary. So I think maybe we should be able to check breakpoints even if we don't have launch.json.
QQ截图20200126172833
@weinand weinand assigned isidorn and unassigned weinand Jan 27, 2020
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jan 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Jan 27, 2020 •
edited by weinand

Yes, this makes sense.
I agree we should show the breakpoints view in the start experience if there is at least one breakpoint set.

@isidorn isidorn added the feature-request Request for new features or functionality label Jan 27, 2020
@isidorn isidorn added this to the January 2020 milestone Jan 27, 2020
@isidorn isidorn added the verification-needed Verification of issue is requested label Jan 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Jan 27, 2020 •
edited

To verify:
Make sure that Breakpoints view is visible in the start experience if and only if you have some breakpoints set. You get the start experience when you have no launch.json.

@connor4312 connor4312 added the verified Verification succeeded label Jan 28, 2020
@connor4312
Copy link
Member

It seems like breakpoints should remain on the bottom where it is during the debug session, looks kind of weird on top. Good otherwise.

image

@isidorn
Copy link
Contributor

isidorn commented Jan 29, 2020

@connor4312 how did you end up in that situation? I can not reproduce it.
This should never happen since the breakpoints view has order 40 and start view has order 10. fyi @sandy081

@connor4312
Copy link
Member

I set a breakpoint and then commented out my launch config... but I'm also unable to reproduce it now/on today's insiders.

@isidorn
Copy link
Contributor

isidorn commented Jan 30, 2020

@connor4312 ok. Let me know if you find repro steps and we can investigate further then. Thanks

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
4 participants
@weinand @isidorn @connor4312 @xubury