Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual .vsix installation can duplicate installed marketplace extensions #89366

Closed
connor4312 opened this issue Jan 27, 2020 · 12 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

@eamodio noticed that installing an extension from a .vsix doesn't replace the marketplace extension. If a marketplace extension was already installed, both the marketplace and vsix version will be installed and persist after refresh. We should probably automatically uninstall the vsix or marketplace version when the other is installed.

image

@connor4312 connor4312 added the extensions Issues concerning extensions label Jan 27, 2020
@eamodio
Copy link
Contributor

eamodio commented Jan 27, 2020

After this happened, I uninstalled one of those entries which vscode showed as removing both. Then I restarted vscode and there were none. Then I re-installed the vsix and now there are 2 again.

I just tried the same thing again... but this time after I uninstalled it, I quit vscode completely, and then manually removed the extension from the ~/.vscode-insiders/extensions folder, restarted vscode, and then installed the vsix and again I have 2 entries

@sandy081
Copy link
Member

I cannot repro this with the vsix I downloaded from Marketplace. Can you please share the vsix you used?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jan 28, 2020
@eamodio
Copy link
Contributor

eamodio commented Jan 28, 2020

Here's the vsix
js-debug-nightly.vsix.zip

@sandy081
Copy link
Member

@connor4312 @eamodio Can't repro. Are you able to repro it still?

@eamodio
Copy link
Contributor

eamodio commented Jan 30, 2020

Yes, it still happens on today's insiders for me with that vsix.

@eamodio
Copy link
Contributor

eamodio commented Jan 30, 2020

And now that I've installed that vsix again as a test, uninstalled it,closed vscode multiple times, and removed the extension from the user profile (since it was left behind) -- something is still left behind. VS Code doesn't show the extension anywhere in the UI (installed/disabled/etc), but if I search for the extension to install the marketplace version, VS Code thinks its kind of installed:

image

Oddly Uninstall is disabled too. Also you're got to love how good the search is 🤦‍♂️

@eamodio
Copy link
Contributor

eamodio commented Jan 30, 2020

I've tried installing another version -- and that seems fine. But if I uninstall that one, it goes away, but the same thing happens when I go to search to install it from the marketplace... there is something left behind somewhere.

@sandy081
Copy link
Member

I suspect these inconsistencies are coming because this extension is made built in and now you have this at two places (built in and installed location).

@sandy081 sandy081 added this to the February 2020 milestone Jan 31, 2020
@eamodio
Copy link
Contributor

eamodio commented Jan 31, 2020

I didn't think the js-debug was built-in yet

@connor4312
Copy link
Member Author

If you were on the latest insiders on the 27th it would have been built-in

@vscodebot vscodebot bot closed this as completed Feb 14, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 14, 2020

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sandy081 sandy081 reopened this Feb 18, 2020
@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Feb 20, 2020
@sandy081 sandy081 modified the milestones: February 2020, March 2020 Feb 26, 2020
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Mar 30, 2020
@sandy081 sandy081 modified the milestones: March 2020, April 2020 Apr 1, 2020
@sandy081 sandy081 modified the milestones: April 2020, May 2020 Apr 29, 2020
@sandy081 sandy081 modified the milestones: May 2020, Backlog, June 2020 Jun 3, 2020
@sandy081
Copy link
Member

sandy081 commented Jun 9, 2020

To verify:

@roblourens roblourens added the verified Verification succeeded label Jul 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @eamodio @connor4312 @sandy081 and others