Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search editor: first line could show a bit of information #89463

Closed
bpasero opened this issue Jan 28, 2020 · 4 comments
Closed

Search editor: first line could show a bit of information #89463

bpasero opened this issue Jan 28, 2020 · 4 comments
Assignees
@JacksonKearl
Labels
feature-request Request for new features or functionality search-editor verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jan 28, 2020

Refs: #89396

I think the first line could indicate how many search results there are, similar to what the search viewlet does:

image

Compared to ST:

image
@JacksonKearl JacksonKearl added feature-request Request for new features or functionality search-editor labels Jan 29, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Jan 29, 2020
@vscodebot
Copy link

vscodebot bot commented Jan 29, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@JacksonKearl
Copy link
Contributor

image

@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2020

@JacksonKearl please add a test plan or verification needed

@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Feb 25, 2020
@bpasero
Copy link
Member Author

bpasero commented Feb 25, 2020

Would add a condition for single values:

image

@bpasero bpasero added the verification-found Issue verification failed label Feb 25, 2020
@bpasero bpasero reopened this Feb 25, 2020
@RMacfarlane RMacfarlane added verified Verification succeeded and removed verification-found Issue verification failed labels Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
feature-request Request for new features or functionality search-editor verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
4 participants
@bpasero @Tyriar @RMacfarlane @JacksonKearl