Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor preview: indicate create/delete/renames better? #89504

Closed
bpasero opened this issue Jan 28, 2020 · 5 comments
Closed

Refactor preview: indicate create/delete/renames better? #89504

bpasero opened this issue Jan 28, 2020 · 5 comments
Assignees
@jrieken
Labels
under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues workspace-edit
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jan 28, 2020

Refs: #89335

I am finding this a bit hard to read, why not do something like " => ". There is possibly a good unicode arrow to use. E.g. diff editor does this:

image

image
@bpasero
Copy link
Member Author

bpasero commented Jan 28, 2020

//cc @misolori for UX. I wonder if all of the create/delete/rename operations should visually indicate better what they are doing:

image

image

@bpasero bpasero changed the title Refactor preview: indicate renames better? Refactor preview: indicate create/delete/renames better? Jan 28, 2020
@jrieken jrieken added under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues workspace-edit labels Jan 28, 2020
@jrieken
Copy link
Member

jrieken commented Jan 28, 2020

Yeah, I am very open for ideas here

@miguelsolorio
Copy link
Contributor

I had a hard time visually understanding the change. Would it help if we repeated the same text in the before/after so it's easier to understand?

image

I also wonder if there's a way to use some type of decorators like Git does to indicate the type of change:
image

@jrieken jrieken added this to the February 2020 milestone Jan 30, 2020
@jrieken
Copy link
Member

jrieken commented Feb 7, 2020

I have pushed a change that uses \u2192 (→) for renames

Screenshot 2020-02-07 at 13 06 21

jrieken added a commit that referenced this issue Feb 7, 2020
@jrieken
use arrow for renames, #89504
0ebabc2
@jrieken
Copy link
Member

jrieken commented Feb 7, 2020

For deleting it now shows a strike out 👇

Screenshot 2020-02-07 at 15 42 44

jrieken added a commit that referenced this issue Feb 7, 2020
@jrieken
show strike through for deletes, #89504
86e4bcf
@jrieken jrieken closed this as completed Feb 10, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues workspace-edit
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@bpasero @jrieken @miguelsolorio