Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fallback on extension command contributions that use icons #89574

Closed
miguelsolorio opened this issue Jan 28, 2020 · 8 comments
Closed

Better fallback on extension command contributions that use icons #89574

miguelsolorio opened this issue Jan 28, 2020 · 8 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Milestone
March 2020

Comments

@miguelsolorio
Copy link
Contributor

Testing #89361

If you have a command that uses Codicons via $(icon) like:

image

The context menu shows the text:

image

IMO, we should strip out the codicon reference in the context menu since it's not supported there. Otherwise authors have to duplicate commands.
@sandy081
Copy link
Member

sandy081 commented Jan 29, 2020 •
edited

Instead is it possible to support codicons in context menu?

@sbatten ?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jan 29, 2020
@sbatten
Copy link
Member

sbatten commented Jan 29, 2020

@misolori codicons are just part of our font, yes? meaning we'd have to fallback to some emoji in the native menus which would probably look out of place.

@miguelsolorio
Copy link
Contributor Author

Correct that native menus would not be able to support it (we could hide it) but in the custom menu we could show it since it's part of our font. But I worry that it might cause inconsistencies across menus.

@sandy081 sandy081 assigned sbatten and unassigned sandy081 Jan 29, 2020
@sandy081
Copy link
Member

We will also have inconsistency if we do not show complete label. I think this issue is same for all context menu actions that can be contributable. Leaving it to @sbatten

@sbatten
Copy link
Member

sbatten commented Jan 29, 2020

I think it should be stripped to be consistent.

@vscodebot vscodebot bot closed this as completed Feb 14, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 14, 2020

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sbatten sbatten reopened this Feb 14, 2020
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues and removed info-needed Issue requires more information from poster labels Feb 14, 2020
@sbatten sbatten added this to the March 2020 milestone Feb 14, 2020
@sbatten sbatten closed this as completed in f88e60c Mar 4, 2020
@sbatten
Copy link
Member

sbatten commented Mar 4, 2020

@misolori Since you created the issue, can you try your test extension to verify?

@miguelsolorio
Copy link
Contributor Author

Verified this works 👍

image

image

@miguelsolorio miguelsolorio added the verified Verification succeeded label Mar 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@sbatten @sandy081 @miguelsolorio