Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View > Reopen With feedback #89604

Closed
bpasero opened this issue Jan 29, 2020 · 2 comments
Closed

View > Reopen With feedback #89604

bpasero opened this issue Jan 29, 2020 · 2 comments
Assignees
@mjbvz
Labels
custom-editors Custom editor API (webview based editors) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jan 29, 2020

Refs: #88426

image

Two things:

  • the command should have a "..." at the end
  • the command should probably be discoverable from the editor too, not just the command palette. Why not put it into the editor title "..." menu?
@bpasero bpasero added the custom-editors Custom editor API (webview based editors) label Jan 29, 2020
@mjbvz mjbvz added this to the February 2020 milestone Jan 29, 2020
@mjbvz mjbvz added the feature-request Request for new features or functionality label Jan 29, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Jan 29, 2020

Thanks for the feedback! I'll look into these in February

@mjbvz mjbvz closed this as completed in 1a81711 Feb 15, 2020
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Feb 15, 2020
@bpasero
Copy link
Member Author

bpasero commented Feb 25, 2020

I would probably put it to the end:

image

@bpasero bpasero added the verified Verification succeeded label Feb 25, 2020
@bpasero bpasero mentioned this issue Feb 25, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
custom-editors Custom editor API (webview based editors) feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@bpasero @mjbvz