New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor not taking the focus back on maximized Panel closing. #89688
Comments
Hi what is the expected result when you do that? The problem you are facing is the editor focus disappears when you close the panel with a short cut key? How do you want us to fix the bug? |
Sorry if it is a bit confusing but I don't understand why the panel has a different behavior when it's maximized or not, that is why I think it must be regarded as a bug, maximized or not the panel should always put the cursor back in the editor when it's closed with the same function. I remade a screencast for more understanding of what is actually going on (with the default keybindings) I bash Ctrl+` multiple times to show you that the cursor is returned into the editor when the panel is not maximized and closed. Hope it makes sense to you. I am from a Emacs background, our philosophy is not trying to use the mouse at all when coding. I've been trying to tweak and find a way around to just toggle maximized panel in and out with a unique shortcut but because of this little detail I can't seem to make it work. Hope you consider this. |
Hey @vdegenne , I understand the issue better. Let me work on resolving it. Hope you will be patient for us to resolve the bug. What machine are you using (Windows/Mac/Linux)? |
@Calebyang93 Sure I know how to be patient when I know people are working hard behind! {
"key": "ctrl+alt+q",
"command": "workbench.action.toggleMaximizedPanel",
"when": "!terminalFocus"
},
{
"key": "ctrl+alt+t",
"command": "workbench.action.closePanel",
"when": "terminalFocus"
} BUT it doesn't work in my case. Now I don't know if it's because the post is old and maybe this issue occurred from a software update or if it's because I am running a linux system. If someone could try on a Windows system that'll give more insight. Another thing, it's not related to a shortcut issue, as I tried in a vanilla version. The issue is specific to the panel design. |
Ok i have to check the code base and get back to you if it is local or vs code based problem. Thanks for troubleshooting and finding possible solutions while we maintain the code base. |
When I change workspace on xfce4 i also loose the focus of the mouse cursor from visual code.. i wonder if its the same issue.. |
reproduction
The video starts after the white screen. Then
Consequences :
Anyway all I try to prove here is that the editor focus is lost when closing the panel with a shortcut only when it's maximized.
Please consider this annoyance as it looks like a bug. Or at least if you don't see that as a bug (because the maximized panel behavior is only meant to be triggered when the panel is already open) see this as a Feature Request. You see from my video on small size window it'd be nice to have a mechanism to open the terminal in all the available space (as if it was just another editor window).
Thanks in advance.
The text was updated successfully, but these errors were encountered: