Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Output panel to use views #89993

Closed
sandy081 opened this issue Feb 4, 2020 · 1 comment
Closed

Adopt Output panel to use views #89993

sandy081 opened this issue Feb 4, 2020 · 1 comment
Assignees
Labels
debt Code quality issues workbench-views Workbench view issues
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Feb 4, 2020

Adopt Output panel to use views

@sandy081 sandy081 added debt Code quality issues workbench-views Workbench view issues labels Feb 4, 2020
@sandy081 sandy081 added this to the February 2020 milestone Feb 4, 2020
@sandy081 sandy081 self-assigned this Feb 4, 2020
sandy081 added a commit that referenced this issue Feb 4, 2020
- register viewlets and panels for containers
- events when view visibility has changed
- small refactorings
@sandy081
Copy link
Member Author

sandy081 commented Feb 4, 2020

@sbatten Needed more API in IViewsService for moving output panel to output view and added them. Most importantly these new APIs replaces the usage of panel service. It has to be make sure while adopting other panels or side bar views that they should not be using panel or viewlet service and to be replaced by IViewsService. Here are the new APIs added to IViewsService:

readonly onDidChangeViewVisibility: Event<{ id: string, visible: boolean }>;
isViewVisible(id: string): boolean;

closeView(id: string): void;

Also moved registering viewlets and panels from View Containers into ViewsService. So this makes it a service that talks to viewlets and panels. Hence we shall replace all usages of panels service and viewlet service in views and panels to use IViewsService.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

1 participant