Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests: Terminal Extension pty terminals should respect dimension overrides #90064

Closed
bpasero opened this issue Feb 5, 2020 · 0 comments · Fixed by #94788
Closed

Integration Tests: Terminal Extension pty terminals should respect dimension overrides #90064

bpasero opened this issue Feb 5, 2020 · 0 comments · Fixed by #94788
Assignees
@Tyriar
Labels
integration-test-failure
Milestone
April 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 5, 2020

https://github.com/microsoft/vscode/runs/427251740#step:13:457

1) window namespace tests Terminal Extension pty terminals should respect dimension overrides:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: 80 == 10
      + expected - actual

      -80
      +10
      
      at extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts:395:8
      at Emitter.fire (out/vs/base/common/file:/home/runner/work/vscode/vscode/src/vs/base/common/event.ts:582:16)
      at ExtHostTerminalService.$acceptTerminalDimensions (out/vs/workbench/api/common/file:/home/runner/work/vscode/vscode/src/vs/workbench/api/common/extHostTerminalService.ts:378:41)
@Tyriar Tyriar mentioned this issue Feb 5, 2020
Closed
@Tyriar Tyriar added this to the February 2020 milestone Feb 5, 2020
Tyriar added a commit that referenced this issue Feb 9, 2020
@Tyriar
Disable flaky integration test
c6a4c11 
Part of #90064
@Tyriar Tyriar modified the milestones: February 2020, March 2020 Feb 24, 2020
@Tyriar Tyriar mentioned this issue Mar 17, 2020
Closed
@Tyriar Tyriar modified the milestones: March 2020, April 2020 Mar 31, 2020
Tyriar added a commit that referenced this issue Apr 9, 2020
@Tyriar
Fix flaky test
183c010 
Terminal Extension pty terminals should respect dimension overrides

Fixes #90064
@Tyriar Tyriar mentioned this issue Apr 9, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
integration-test-failure
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Fix flaky test microsoft/vscode
2 participants
@bpasero @Tyriar