Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running web out of sources is broken #90162

Closed
jmbockhorst opened this issue Feb 6, 2020 · 4 comments
Closed

Running web out of sources is broken #90162

jmbockhorst opened this issue Feb 6, 2020 · 4 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded web Issues related to running VSCode in the web
Milestone
February 2020

Comments

@jmbockhorst
Copy link
Contributor

Running web out of sources does not work as of b1c5e2f because the vscode-api-tests extension cannot activate. When removing the changes from this commit to extensions\vscode-api-tests\src\extension.ts it works as expected.

folder

notification

Version: 1.42.0-insider (user setup)
Commit: ae08d54
OS: Windows_NT x64 10.0.19546

Steps to Reproduce:

  1. yarn web
  2. The extension doesn't load and you cannot view any files.
@bpasero bpasero assigned mjbvz and unassigned bpasero Feb 7, 2020
@bpasero bpasero added important Issue identified as high-priority web Issues related to running VSCode in the web labels Feb 7, 2020
@bpasero bpasero added this to the February 2020 milestone Feb 7, 2020
@bpasero
Copy link
Member

bpasero commented Feb 7, 2020

@mjbvz can you check

bpasero added a commit that referenced this issue Feb 7, 2020
@bpasero
workaround #90162
df3764a
@bpasero
Copy link
Member

bpasero commented Feb 7, 2020

Pushed df3764a as workaround.

@mjbvz
Copy link
Contributor

mjbvz commented Feb 7, 2020

Thanks for the quick workaround @bpasero!

This was caused by b1c5e2f. Url and TextEncoder are both global types in node but unfortunately the node TypeScript typings don't mark them as such. That's why I added the import instead.

I'll push a fix tomorrow so that we can properly run the extension in both browsers and node.

@Chatina73
Copy link

HP Steam, i have 2 os boot image not loadi5

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 7, 2020
@mjbvz mjbvz closed this as completed in b46d35c Feb 7, 2020
@joaomoreno joaomoreno added the verified Verification succeeded label Feb 27, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
5 participants
@joaomoreno @bpasero @mjbvz @jmbockhorst @Chatina73