Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus doesn't follow search moveView but focuses where it was prior to move #90277

Closed
ArturoDent opened this issue Feb 8, 2020 · 0 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Milestone

Comments

@ArturoDent
Copy link

Using the unbound command workbench.view.search.moveView focus goes to where the search view is being moved from, not to.

So if search is in the panel and one triggers the following keybinding, focus goes to the panel. And if the search view is in the sidebar, and then moved to the panel, focus goes to the sidebar - when focus started at the editor in both cases. I would expect focus to either not leave the editor at all (first choice) or go to the search view wherever it moved to (second choice).

So it is odd that focus goes to where search just left.

Using this keybinding (all extensions disabled):

{
   "key": "alt+e",
   "command": "workbench.view.search.moveView"
 },

Does this issue occur when all extensions are disabled?: Yes

Version: 1.42.0 (user setup)
Commit: ae08d54
Date: 2020-02-06T10:51:34.058Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.19559

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Feb 20, 2020
@sbatten sbatten added this to the February 2020 milestone Feb 20, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

3 participants