Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-select QuickPick using canPickMany is missing a confirmation button #90365

Closed
mjcrouch opened this issue Feb 10, 2020 · 4 comments
Closed

Multi-select QuickPick using canPickMany is missing a confirmation button #90365

mjcrouch opened this issue Feb 10, 2020 · 4 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
February 2020

Comments

@mjcrouch
Copy link
Contributor

mjcrouch commented Feb 10, 2020 •
edited

When opening a quick pick that has multi-select enabled, there is no confirmation button. The only way I have found to confirm the selection by clicking into the quick pick text and pressing enter.

1581341713001_image001

I'm fairly sure I'm not imagining that there was previously a confirmation button on 1.41.1, though I'm not currently in a position to prove it!

  • VSCode Version: 1.42.0
  • OS Version: Win 7 Enterprise

Steps to Reproduce:

  1. Open a multi-select quickpick
  2. Observe the lack of a button

Does this issue occur when all extensions are disabled?: Not checked as I don't know a core menu that has multi-select
@vscodebot vscodebot bot removed the new release label Feb 11, 2020
@mjcrouch mjcrouch mentioned this issue Feb 12, 2020
Open
@shasank
Copy link

shasank commented Feb 13, 2020

Yes, the same was working properly in 1.41.1.
image

@chrmarti chrmarti added this to the February 2020 milestone Feb 18, 2020
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Feb 18, 2020
@chrmarti chrmarti mentioned this issue Feb 25, 2020
Closed
@frnk01
Copy link

frnk01 commented Feb 25, 2020

@chrmarti I’ve tried pressing enter multiple times. It does not work. The list disappears but the selection is not saved.

@JacksonKearl JacksonKearl added the verified Verification succeeded label Feb 28, 2020
@JacksonKearl
Copy link
Contributor

@chrmarti is this in todays build? Not seeing button, but I did notice focus returns to the input on selection, so you can just submit with enter (no mouse needed).

image

@JacksonKearl JacksonKearl added verification-found Issue verification failed and removed verification-found Issue verification failed labels Feb 28, 2020
@JacksonKearl
Copy link
Contributor

Disregard. I was using an old build.

@svipas svipas mentioned this issue Mar 4, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
5 participants
@frnk01 @shasank @JacksonKearl @chrmarti @mjcrouch