Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Trying to add a disposable to a DisposableStore that has already been disposed of #90432

Closed
bpasero opened this issue Feb 11, 2020 · 0 comments
Assignees
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 11, 2020

ExtensionsTipsService Test
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations when galleryService is absent
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations during extension development
    ✓ ExtensionTipsService: No workspace recommendations or prompts when extensions.json has empty array
    ✓ ExtensionTipsService: Prompt for valid workspace recommendations
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations if they are already installed
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations with casing mismatch if they are already installed
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations if ignoreRecommendations is set
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations if showRecommendationsOnlyOnDemand is set
    ✓ ExtensionTipsService: No Prompt for valid workspace recommendations if ignoreRecommendations is set for current workspace
    ✓ ExtensionTipsService: No Recommendations of globally ignored recommendations
    ✓ ExtensionTipsService: No Recommendations of workspace ignored recommendations
    ✓ ExtensionTipsService: Able to retrieve collection of all ignored recommendations
    ✓ ExtensionTipsService: Able to dynamically ignore/unignore global recommendations
    ✓ test global extensions are modified and recommendation change event is fired when an extension is ignored
[6414:0211/101602.054191:INFO:CONSOLE(117)] "Error: Trying to add a disposable to a DisposableStore that has already been disposed of. The added object will be leaked!
    at DisposableStore.add (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/lifecycle.js:117:34)
    at ExtensionTipsService._register (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/lifecycle.js:141:32)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/contrib/extensions/browser/extensionTipsService.js:87:22", source: file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/lifecycle.js (117)
    ✓ ExtensionTipsService: Get file based recommendations from storage (old format)
    ✓ ExtensionTipsService: Get file based recommendations from storage (new format)
@sandy081 sandy081 assigned JacksonKearl and unassigned sandy081 Feb 11, 2020
@JacksonKearl JacksonKearl added this to the February 2020 milestone Feb 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants