Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Extension pty terminals should respect dimension overrides #90437

Closed
bpasero opened this issue Feb 11, 2020 · 1 comment
Closed

Terminal Extension pty terminals should respect dimension overrides #90437

bpasero opened this issue Feb 11, 2020 · 1 comment
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) integration-test-failure
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 11, 2020

https://monacotools.visualstudio.com/DefaultCollection/Monaco/_build/results?buildId=67143&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=384d930d-6775-58a0-3817-a8714909e89a&l=398

  1) window namespace tests Terminal Extension pty terminals should respect dimension overrides:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: 105 == 10
      + expected - actual

      -105
      +10
      
      at extensions\vscode-api-tests\src\singlefolder-tests\terminal.test.ts:395:8
      at l.fire (d:\a\1\vscode-reh-web-win32-x64\out\vs\server\remoteExtensionHostProcess.js:48:652)
      at y.$acceptTerminalDimensions (d:\a\1\vscode-reh-web-win32-x64\out\vs\server\remoteExtensionHostProcess.js:662:970)
      at processTicksAndRejections (internal/process/task_queues.js:89:5)
bpasero added a commit that referenced this issue Feb 11, 2020
@bpasero
skip terminal test (#90437)
ae78db0
@Tyriar Tyriar added this to the March 2020 milestone Feb 11, 2020
@Tyriar
Copy link
Member

Tyriar commented Mar 17, 2020

/duplicate #90064

@Tyriar Tyriar closed this as completed Mar 17, 2020
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) integration-test-failure
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @Tyriar