Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userDataSyncService: Broken hasPreviouslySynced(), hasLocalData #90557

Closed
scovetta opened this issue Feb 12, 2020 · 1 comment
Closed

userDataSyncService: Broken hasPreviouslySynced(), hasLocalData #90557

scovetta opened this issue Feb 12, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Milestone

Comments

@scovetta
Copy link
Member

scovetta commented Feb 12, 2020

These two functions in userDataSyncService.ts look to be broken:

	async hasPreviouslySynced(): Promise<boolean> {
		await this.checkEnablement();
		for (const synchroniser of this.synchronisers) {
			if (await synchroniser.hasPreviouslySynced()) {
                             // Shouldn't there be a return true here?
			}
		}
		return false;
	}

	private async hasLocalData(): Promise<boolean> {
		await this.checkEnablement();
		for (const synchroniser of this.synchronisers) {
			if (await synchroniser.hasLocalData()) {
                             // Shouldn't there be a return true here?
			}
		}
		return false;
	}
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug settings-sync labels Feb 13, 2020
@sandy081 sandy081 added this to the February 2020 milestone Feb 13, 2020
@sandy081
Copy link
Member

Good catch and code review. Due to the refactoring I did recently.

@roblourens roblourens added the verified Verification succeeded label Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants