Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use rootPath in built-in extension #90562

Closed
2 of 3 tasks
mjbvz opened this issue Feb 13, 2020 · 4 comments
Closed
2 of 3 tasks

Don't use rootPath in built-in extension #90562

mjbvz opened this issue Feb 13, 2020 · 4 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 13, 2020

Discovered as part of #88391

Looks like some of out built-in extensions are still using rootPath:

@mjbvz mjbvz added the debt Code quality issues label Feb 13, 2020
@roblourens
Copy link
Member

lol, how did I miss those?

roblourens added a commit that referenced this issue Feb 13, 2020
@roblourens
Copy link
Member

The builtin PHP validation is very simple and I've wanted to delete it, and nobody has ever complained that it doesn't work correctly in multiroot, so I'm not bothering to actually fix it for multiple folders.

@aeschli aeschli removed their assignment Feb 18, 2020
@octref octref added this to the February 2020 milestone Feb 18, 2020
@gjsjohnmurray
Copy link
Contributor

Looks like #87493 is this for Emmet

@roblourens roblourens removed their assignment Feb 26, 2020
@octref
Copy link
Contributor

octref commented Feb 26, 2020

Emmet seems a bit more complicated — I'll track it in #87493 then.

@octref octref closed this as completed Feb 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

5 participants