Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes appear on every window #90632

Closed
brandondrew opened this issue Feb 13, 2020 · 9 comments · Fixed by #90675
Closed

Release notes appear on every window #90632

brandondrew opened this issue Feb 13, 2020 · 9 comments · Fixed by #90675
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues release-notes Release notes issues verified Verification succeeded
Milestone

Comments

@brandondrew
Copy link

I would like to see the release notes when there's an update, because there are always useful additions that I want to know about, but currently VS Code:

  1. regularly re-opens release notes that I have already read,
  2. opens release notes in EVERY SINGLE WINDOW.

image

These have been happening for years. Please fix them before I jump off a bridge! 😱

There should never be any reason to automatically open them more than ONE time. Perhaps consider using the OS notification system to send ONE notification. If you can't do that, please open ONE window with the release notes, instead of one tab in every window.

@gjsjohnmurray
Copy link
Contributor

/needsMoreInfo does this reproduce if you run with all extensions disabled?

@brandondrew
Copy link
Author

Since some of the conditions to reproduce it (a new release) are outside of my control, and outside of my knowledge until I see the release notes, that's very hard to answer.

Are you trying to tell me that you do not have the release notes appear in every single window when you reopen Visual Studio Code and there's a new release? And that you never have them appear again after you've already read them? Since I've seen this happen SO many times, I guessed it happened quite widely.

@bpasero
Copy link
Member

bpasero commented Feb 14, 2020

This seems to be triggered from update, moving to Joao.

@bpasero bpasero assigned joaomoreno and unassigned bpasero Feb 14, 2020
@bpasero bpasero added the install-update VS Code installation and upgrade system issues label Feb 14, 2020
@joaomoreno joaomoreno added the release-notes Release notes issues label Feb 14, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Feb 14, 2020

@brandondrew Yes there is a known issue: when opening release notes, every window opens them. It's pretty dramatic in your case since you seem to have ~20 windows open.

But release notes should not appear twice, unless there's been a recovery update. There was one yesterday: 1.42.1... so that might explain it?

@joaomoreno joaomoreno changed the title BUGS: opening dozens of copies of release notes, and doing so repeatedly Release notes appear on every window Feb 14, 2020
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 14, 2020
@joaomoreno joaomoreno added this to the February 2020 milestone Feb 14, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Feb 14, 2020

I could swear this issue had been fixed in the past... and I was right. Original issue is #77583 and fix was 01c2f55

@bpasero This got broken by f0b9953#diff-10b67ccbd65ac0e04fe13cd734b466f4L128.

@brandondrew
Copy link
Author

Muito obrigado João! 👏🏻👏🏻👏🏻

@joaomoreno
Copy link
Member

De nada! Make sure you let us know when stuff annoys you. Sometimes it seems obvious that an issue would annoy everyone but sometimes it just doesn't. 👍

@alexr00
Copy link
Member

alexr00 commented Feb 27, 2020

@joaomoreno is there a good way to verify this? If not, I have already verified by code review.

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Feb 27, 2020
@joaomoreno
Copy link
Member

Code review should be 🆗

@joaomoreno joaomoreno added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues release-notes Release notes issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants