Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error notification when turning off sync while signed out #90916

Closed
RMacfarlane opened this issue Feb 18, 2020 · 2 comments
Closed

Error notification when turning off sync while signed out #90916

RMacfarlane opened this issue Feb 18, 2020 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Milestone
February 2020

Comments

@RMacfarlane
Copy link
Contributor

Issue Type: Bug

  1. Sign in and start settings sync
  2. Run Sync: Sign Out
  3. Run Sync: Turn off Sync

Notification is shown that says "Error while turning off sync: Not Authenticated. Please sign in to start sync."

VS Code version: Code - Insiders 1.43.0-insider (595f984, 2020-02-18T13:53:05.200Z)
OS version: Darwin x64 18.7.0
@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug settings-sync labels Feb 18, 2020
@RMacfarlane RMacfarlane added this to the February 2020 milestone Feb 18, 2020
@RMacfarlane
Copy link
Contributor Author

@sandy081 There are many places we call checkEnablement which checks if there's a token. IMO I think we shouldn't check the token status at all in that function, it seems like it shouldn't matter if you're signed in or not to perform all of these operations

@sandy081
Copy link
Member

I encountered this today and felt the same and removed this check for this method - 6b1e093

But after thinking a bit, this service UserDataSyncService should not bother about authentication. UserDataSyncStoreService is the one that should be aware of auth token and throw proper errors. Hence removed auth stuff from UserDataSyncService.

@alexr00 alexr00 added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@RMacfarlane @sandy081 @alexr00