Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on a icon in the side bar should not close the viewlet but refocus it instead #90995

Closed
dbaeumer opened this issue Feb 19, 2020 · 17 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

I very oftern click on the debug icon in the side bar and want to focus it. However if it is focused it closes it which is very disturbing. I would like to request an option to allow me to re-focus instead of closing.

@bpasero bpasero added layout General VS Code workbench layout issues feature-request Request for new features or functionality labels Feb 19, 2020
@bpasero bpasero assigned sbatten and unassigned bpasero Feb 19, 2020
@sbatten
Copy link
Member

sbatten commented Feb 19, 2020

hmm, shouldn't this just be handled by clicking inside the viewlet?

@dbaeumer
Copy link
Member Author

This forces me to first look if the debug view is active :-). Here is what usually happens:

  • explorer is in front
  • I want to debug and press the debug view icon. Everything is nice
  • I do some code fixes and want to debug can and press the debug view icon (view closes :-( )

I am so used to clicking the icon when I want to debug that I find it very disturbing when the view closes when I click on it.

@sbatten sbatten added this to the Backlog Candidates milestone Mar 10, 2020
@vscodebot
Copy link

vscodebot bot commented Mar 10, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@sbatten
Copy link
Member

sbatten commented Mar 10, 2020

@dbaeumer team had some resistance to this, thus leaving it to candidates.

@dbaeumer
Copy link
Member Author

What's about a setting. I can understand that breaking this might cause unnecessary swirl.

@dbaeumer
Copy link
Member Author

dbaeumer commented Apr 30, 2020

@sbatten any chance to convince you? I am absolutely happy with a settings.

@dbaeumer
Copy link
Member Author

@sbatten any feedback?

@dbaeumer dbaeumer reopened this May 11, 2020
@sbatten
Copy link
Member

sbatten commented May 12, 2020

When I first had this configured the teams was even resistant to a setting but I might add this anyway. How do you feel about letting double click anywhere on the activity bar to hide. Single click only changes focus.

@dbaeumer
Copy link
Member Author

I like this but it might cause problems due to muscle memory. You would need to put this behind a setting.

@sbatten sbatten modified the milestones: Backlog Candidates, June 2020 May 12, 2020
@sbatten sbatten reopened this May 12, 2020
@dbaeumer
Copy link
Member Author

@sbatten when coming to Redmond the next time :-) I will buy you a beer.

@sbatten
Copy link
Member

sbatten commented Jul 1, 2020

sorry dirk, next month :P

@sbatten sbatten modified the milestones: June 2020, July 2020 Jul 1, 2020
@dbaeumer
Copy link
Member Author

dbaeumer commented Jul 1, 2020

No problem :-)

@sbatten sbatten added the verification-needed Verification of issue is requested label Jul 31, 2020
@dbaeumer
Copy link
Member Author

dbaeumer commented Aug 3, 2020

THANKS !!!

@dbaeumer dbaeumer added the verified Verification succeeded label Aug 3, 2020
@dbaeumer
Copy link
Member Author

dbaeumer commented Aug 3, 2020

and verified :-)

annkamsk pushed a commit to annkamsk/vscode that referenced this issue Aug 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @dbaeumer @sbatten and others