Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+Up/Down and Stift+Tab trigger new search if focus "files to include/exclude" fields #91031

Closed
IllusionMH opened this issue Feb 19, 2020 · 1 comment
Closed

Ctrl+Up/Down and Stift+Tab trigger new search if focus "files to include/exclude" fields #91031

IllusionMH opened this issue Feb 19, 2020 · 1 comment
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug search-editor verified Verification succeeded
Milestone
February 2020

Comments

@IllusionMH
Copy link
Contributor

Issue Type: Bug

When Ctrl+↑ or Shift+Tab focus "files to include" or "files to exclude" fields new search is triggered even if no changes were made. There are no problems if these actions focus "Search" and "Replace" fields or if I use Tab.

  1. Make sure that search.searchOnType is true and you have search results in Find in Files (it's also possible to remove few results to see effect)
  2. Focus "files to exclude" field
  3. Press Ctrl+↑
  4. Searh is performed again (all result are resotred if some were removed)
  5. Press Ctrl+↑ again (focus will be in "Search" or "Replace" field)
  6. No new search until triggered by change

/cc @JacksonKearl

VS Code version: Code - Insiders 1.43.0-insider (13d7b30, 2020-02-19T17:43:05.977Z)
OS version: Windows_NT x64 10.0.19564

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4650U CPU @ 1.70GHz (4 x 2295)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 7.91GB (1.77GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none
@JacksonKearl JacksonKearl self-assigned this Feb 19, 2020
@JacksonKearl JacksonKearl added the bug Issue identified by VS Code Team member as probable bug label Feb 20, 2020
@JacksonKearl JacksonKearl added this to the February 2020 milestone Feb 20, 2020
@JacksonKearl
Copy link
Contributor

Thanks!

More complicated of a fix than strictly necessary but it cleans things up quite a bit.

@rebornix rebornix added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug search-editor verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@rebornix @IllusionMH @JacksonKearl