Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate sync and auth functionalities #91089

Closed
sandy081 opened this issue Feb 20, 2020 · 2 comments
Closed

Separate sync and auth functionalities #91089

sandy081 opened this issue Feb 20, 2020 · 2 comments
Assignees
@RMacfarlane @sandy081
Labels
authentication Issues with the Authentication platform debt Code quality issues settings-sync
Milestone
April 2020

Comments

@sandy081
Copy link
Member

sandy081 commented Feb 20, 2020 •
edited

Currently UserDataSync is mixed up with auth and sync features. To avoid a kitchen sink, we shall separate these two.
@sandy081 sandy081 added debt Code quality issues settings-sync authentication Issues with the Authentication platform labels Feb 20, 2020
@sandy081 sandy081 added this to the March 2020 milestone Feb 20, 2020
@RMacfarlane
Copy link
Contributor

@sandy081 Where do you expect to draw the line between these? Should the gear not update when you're not signed in?

IMO, since auth is a requisite for having sync, completely separating them doesn't make sense.

@sandy081
Copy link
Member Author

In terms of code organisation they should be separate. Currently sync is taking care of auth management in core. Instead, I would suggest to move auth management as a separate folder and allow sync to use services or context defined there.

@sandy081 sandy081 modified the milestones: March 2020, Backlog, April 2020 Mar 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

@sandy081 sandy081

Labels
authentication Issues with the Authentication platform debt Code quality issues settings-sync
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@RMacfarlane @sandy081