Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo/Redo: better name for "Workspace Edit" #91369

Closed
bpasero opened this issue Feb 25, 2020 · 7 comments
Closed

Undo/Redo: better name for "Workspace Edit" #91369

bpasero opened this issue Feb 25, 2020 · 7 comments
Assignees
@alexdima
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workspace-edit
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 25, 2020

Refs: #91248

If I do a "Rename" workspace edit, we should ideally use that as a label over the generic "Workspace Edit".
@jrieken jrieken self-assigned this Feb 25, 2020
@jrieken jrieken added feature-request Request for new features or functionality workspace-edit labels Feb 25, 2020
@jrieken
Copy link
Member

jrieken commented Feb 25, 2020

This will also be helpful for refactor preview

@jrieken jrieken added this to the March 2020 milestone Feb 25, 2020
@jrieken
Copy link
Member

jrieken commented Feb 25, 2020

In fact, there already is IBulkEditOptions#label and rename sets a value for it

@alexdima
Copy link
Member

This looked low hanging, so I just tackled it.

@alexdima alexdima modified the milestones: March 2020, February 2020 Feb 26, 2020
@alexdima alexdima added the verification-needed Verification of issue is requested label Feb 26, 2020
jrieken added a commit that referenced this issue Feb 26, 2020
@jrieken
use CodeAction#title as bulk edit label option, #91369
2654876
@jrieken
Copy link
Member

jrieken commented Feb 26, 2020

I have pushed another change that makes code actions also set a label

@bpasero bpasero added the verified Verification succeeded label Feb 27, 2020
@bpasero
Copy link
Member Author

bpasero commented Feb 27, 2020

image

Still a clash of quotes, but that is just polish or we leave it.

@alexdima
Copy link
Member

@bpasero I tackled that in a different issue with feedback from you, but I don't think there is an insiders available yet.

@bpasero
Copy link
Member Author

bpasero commented Feb 27, 2020

@alexdima ah ok good, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workspace-edit
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@bpasero @jrieken @alexdima