Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding already disposed disposable to DisposableStore in textFileEditorModel.ts #91396

Closed
Tyriar opened this issue Feb 25, 2020 · 0 comments
Closed

Adding already disposed disposable to DisposableStore in textFileEditorModel.ts #91396

Tyriar opened this issue Feb 25, 2020 · 0 comments
Assignees
@bpasero
Labels
debt Code quality issues workbench-editors Managing of editor widgets in workbench window
Milestone
February 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2020

I don't have a repro, was testing GH issue links at the time.

image

Error: Trying to add a disposable to a DisposableStore that has already been disposed of. The added object will be leaked!
    at l.add (lifecycle.ts:134)
    at y._register (lifecycle.ts:164)
    at y.installModelListeners (textFileEditorModel.ts:441)
    at y.doCreateTextModel (textFileEditorModel.ts:419)
    at y.loadFromContent (textFileEditorModel.ts:395)
    at y.loadFromFile (textFileEditorModel.ts:337)
    at processTicksAndRejections (internal/process/task_queues.js:85)
    at async Object.factory (textFileEditorModelManager.ts:122)
@bpasero bpasero added this to the February 2020 milestone Feb 25, 2020
@bpasero bpasero added workbench-editors Managing of editor widgets in workbench window debt Code quality issues labels Feb 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@bpasero @Tyriar