Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: View title bar is not accessible with Orca #91602

Closed
rebornix opened this issue Feb 26, 2020 · 3 comments
Closed

Accessibility: View title bar is not accessible with Orca #91602

rebornix opened this issue Feb 26, 2020 · 3 comments
Assignees
@isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded
Milestone
March 2020

Comments

@rebornix
Copy link
Member

Re #91063

  • OS: Ubuntu 18.04
  • Screen Reader: Orca

Bug:

  • Open File Explorer
  • Tab through the Views, Open Editors, Explorer, Outline, Timeline
  • Orca doesn't read the name for each view title, while Voice Over on macOS does.
@rebornix
Copy link
Member Author

Didn't reproduce this issue in Debug View.

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2020

Interesting. Assigning to march to investigate more then.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues linux Issues with VS Code on Linux labels Feb 27, 2020
@isidorn isidorn added this to the March 2020 milestone Feb 27, 2020
@isidorn isidorn closed this as completed in 0b3510d Mar 9, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 9, 2020

@rebornix this is a good catch.
The issue here is that the Outline and Timeline view do not specify an ariaHeaderLabel when they are being constructed.

This issue was that attribute was not mandatory, thus a lot of clients simply did not pass it.
I think I have simplified things quite a bit by computing the ariaLabel from the title and removing the ariaHeaderLabel attribute to not be controlled by clients.
Now all views proprely have an ariaLabel set.

fyi @sandy081 @sbatten @joaomoreno

@isidorn isidorn mentioned this issue Mar 9, 2020
Closed
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 9, 2020
@connor4312 connor4312 added verified Verification succeeded and removed verified Verification succeeded labels Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@rebornix @isidorn @connor4312