Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log (Sync) is empty #91696

Closed
alexr00 opened this issue Feb 27, 2020 · 5 comments
Closed

Log (Sync) is empty #91696

alexr00 opened this issue Feb 27, 2020 · 5 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2020

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 27, 2020

I was testing #90150 and made my settings file really big. Then I went to the Output for Log (Sync) to see what was happening. The Output is empty. When I Open Log File the file userDataSync.log is also empty. The Copy Path command only copies the file name, so I think the file doesn't exist.
@alexr00
Copy link
Member Author

alexr00 commented Feb 27, 2020

Huh, looks like sync had gotten turned off and that's why the log was empty. It might be good to have something in the log that indicates that sync isn't on. Or just don't show it in the Output drop down if the file doesn't exist.

@sandy081 sandy081 added settings-sync under-discussion Issue is under discussion for relevance, priority, approach labels Feb 27, 2020
@sandy081
Copy link
Member

Hmm yes and no. Not sure how often this would be that going to sync log when sync is turned off in a new session.

I will keep it open in case if users also get into this.

@alexr00
Copy link
Member Author

alexr00 commented Feb 27, 2020

The problem was that I thought sync was on (because I had turned it on), and didn't understand why the log was empty. I soon thought to look for the Turn Sync On command, but it would have been better if the log had said that sync got turned off.

@sandy081
Copy link
Member

I see. Agreed to add status of the sync when VS Code is started.

@sandy081 sandy081 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Feb 27, 2020
@sandy081 sandy081 added this to the March 2020 milestone Feb 27, 2020
@sandy081 sandy081 modified the milestones: March 2020, April 2020 Mar 30, 2020
@sandy081 sandy081 modified the milestones: April 2020, Backlog Apr 28, 2020
@sandy081 sandy081 modified the milestones: Backlog, July 2020 Jul 20, 2020
sandy081 added a commit that referenced this issue Jul 20, 2020
@sandy081
#91696 start-up log
ff66cdb
joaomoreno pushed a commit that referenced this issue Jul 21, 2020
@sandy081 @joaomoreno
Fix #91696
679cd61
joaomoreno pushed a commit that referenced this issue Jul 21, 2020
@sandy081 @joaomoreno
#91696 start-up log
c4519c6
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Aug 3, 2020
@sandy081
Copy link
Member

sandy081 commented Aug 3, 2020

To verify: Make sure Settings Sync log shows status of the Sync always (even when it is disabled).

@alexr00 alexr00 added the verified Verification succeeded label Aug 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders settings-sync verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
3 participants
@sandy081 @alexr00 and others