Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editors: backup has cancellation but others not? #91702

Closed
bpasero opened this issue Feb 27, 2020 · 3 comments
Closed

Custom editors: backup has cancellation but others not? #91702

bpasero opened this issue Feb 27, 2020 · 3 comments
Assignees
@mjbvz
Labels
api custom-editors Custom editor API (webview based editors) on-testplan
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 27, 2020

Refs #91325

I am not sure why backup comes with cancellation support but e.g. save does not. Would we not cancel a save when a second save attempt is made? I also wonder about the other methods.
@mjbvz mjbvz added api custom-editors Custom editor API (webview based editors) labels Feb 27, 2020
@mjbvz mjbvz added this to the March 2020 milestone Feb 27, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 27, 2020 •
edited

Yes, probably makes sense for save at least.

I added a cancellation on backup because I expected it to take the most time, but save could also be long running

@bpasero
Copy link
Member Author

bpasero commented Feb 28, 2020

I think we should add it to all long running operations even if we do not call it in the beginning.

mjbvz added a commit that referenced this issue Mar 4, 2020
@mjbvz
Add cancellation on CustomEditor.save
077cd38 
For #91702
@mjbvz
Copy link
Contributor

mjbvz commented Mar 25, 2020

I have added cancellation tokens to all file operations (save, backup) as well as to the providers themselves

@mjbvz mjbvz closed this as completed Mar 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api custom-editors Custom editor API (webview based editors) on-testplan
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @mjbvz