Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguation tab folder hint is using wrong slash ".\" in WSL #92030

Closed
Tyriar opened this issue Mar 4, 2020 · 1 comment
Closed

Disambiguation tab folder hint is using wrong slash ".\" in WSL #92030

Tyriar opened this issue Mar 4, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 4, 2020

It seems to be using the slash based on the frontend OS, not the backend.

image

Repro:

  1. Open WSL workspace
  2. Open 2 files with same name
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues labels Mar 5, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 5, 2020
@bpasero bpasero closed this as completed in 9f7b100 Mar 5, 2020
@bpasero
Copy link
Member

bpasero commented Mar 5, 2020

Good catch, I am using IRemotePathService#path now for the code that shortens the tab labels when there are duplicates. Needs verification though.

@roblourens roblourens added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants