Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Run and "Debug" is always greyed out when the editor first opens #92126

Closed
connor4312 opened this issue Mar 5, 2020 · 8 comments · Fixed by #94853
Closed

"Run and "Debug" is always greyed out when the editor first opens #92126

connor4312 opened this issue Mar 5, 2020 · 8 comments · Fixed by #94853
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@connor4312
Copy link
Member

  1. Open the debug view and a .js file
  2. Reload the window
  3. Observe that the debug view doesn't seem to recognize a file is open
  4. Switching to another file and back again fixes it

https://memes.peet.io/img/20-03-26eb4bdb-8713-492d-b0f4-cbff67f9678c.webm

@connor4312 connor4312 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 5, 2020
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 6, 2020
@isidorn isidorn added this to the March 2020 milestone Mar 6, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 6, 2020

I can not reproduce this with latest VS Code out of source.
I can reproduce in vscode insiders. Thus it seems like I fixed the issue.
Let me know if you can repro out of source and I will reopen.

Potentially a candidate. Let me know if you think it is and I can search for the exact fix and port it to the release branch if we do a recovery release.

@isidorn isidorn closed this as completed Mar 6, 2020
@connor4312
Copy link
Member Author

I don't think this is candidate worthy. Thanks for looking into it!

@connor4312
Copy link
Member Author

I can actually still reproduce this, though it seems racey.

  1. Create a brand new folder
  2. Create some hello.js in it, and open it.
  3. Open the debug view
  4. Reload the window
  5. Run and Debug button is greyed out

https://memes.peet.io/img/20-04-d5946617-17ff-4281-b655-f006020b5ac3.webm

@connor4312 connor4312 reopened this Apr 2, 2020
@connor4312 connor4312 added the verification-found Issue verification failed label Apr 2, 2020
@isidorn isidorn closed this as completed in aef342f Apr 2, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 2, 2020

Pushed a potential fix. Can not really verify if it fixes since can not repro out of source.

@Tyriar Tyriar removed the verification-found Issue verification failed label Apr 3, 2020
@connor4312
Copy link
Member Author

This still repro's. I'll move this to next month and debug on my machine since it doesn't repro for you.

@connor4312 connor4312 reopened this Apr 3, 2020
@connor4312 connor4312 modified the milestones: March 2020, April 2020 Apr 3, 2020
@connor4312 connor4312 self-assigned this Apr 3, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 6, 2020

@connor4312 thanks for moving it. No need to debug on your machine since now I can reproduce it. But I can only reproduce it in the built version which makes debugging it a bit harder.

@jeanp413
Copy link
Contributor

I got a fix for this though I couldn't actually verify it since I cannot repro out of source but it does happen in stable and insiders. I'll create a PR so you can try it out.

@isidorn
Copy link
Contributor

isidorn commented Apr 10, 2020

As mentioned in the PR I fully built VS Code from your changes and the issue is fixed.
Great fix and thanks for help @jeanp413

@connor4312 connor4312 added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants