Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot assign custom hotkey to "Clear filter" in Problems pane #92189

Closed
pe224 opened this issue Mar 6, 2020 · 1 comment
Closed

Cannot assign custom hotkey to "Clear filter" in Problems pane #92189

pe224 opened this issue Mar 6, 2020 · 1 comment
Assignees
@sandy081
Labels
error-list Problems view feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2020

Comments

@pe224
Copy link

pe224 commented Mar 6, 2020

  • VSCode Version: 1.43.0-insider (user setup)
  • OS Version: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Go to Problems pane, enter some text into filter box.
  2. Escape clears the filter box. I tried every command which is assigned to Escape in default keybindings and assigned each to ctrl+c. However, I could not clear the input box that way.
    Escape seems to be special-cased somehow, maybe due to this?

Expected behavior:
I can assign the custom keybinding ctrl+c to clear this filter.

Does this issue occur when all extensions are disabled?: Yes
@sandy081 sandy081 added error-list Problems view feature-request Request for new features or functionality labels Mar 9, 2020
@sandy081 sandy081 added this to the March 2020 milestone Mar 9, 2020
@sandy081
Copy link
Member

sandy081 commented Mar 9, 2020

Yes, this is not exposed and its true for all input boxes and esc is hardcoded to clear the input box. This is done because of some limitations.

So it is not possible to remove the esc key to clear, instead I can provide an action to clear filter input. This is unbound to any key by default and you can bind it to the key you like.

problems.action.clearFilterText

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Mar 30, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
error-list Problems view feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@pe224 @JacksonKearl @sandy081