Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening settings UI when .json needed #92264

Closed
voltflake opened this issue Mar 9, 2020 · 4 comments
Closed

Opening settings UI when .json needed #92264

voltflake opened this issue Mar 9, 2020 · 4 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
March 2020

Comments

@voltflake
Copy link

  • VSCode Version: latest 1.43.0-insider
  • OS Version: Linux x64 5.3.0-42-generic, also tested on newest Windows 10 x64

Steps to Reproduce:

  1. Use any global debug configuration
  2. Click on "settings" button called open launch.json, near selected debug configuration
  3. When expecting settings.json, vscode will open settings UI

Does this issue occur when all extensions are disabled?: Yes
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 9, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 10, 2020

Good catch. I have pushed a fix for this which you can see in vscode insiders from Wednesday. Let us know if it works for you know (though I verified and it is fixed for me).
Thanks!

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 10, 2020
@isidorn isidorn added this to the March 2020 milestone Mar 10, 2020
@isidorn
Copy link
Contributor

isidorn commented Mar 24, 2020

Did you get a chance to try this out in VS Code insiders? Asking because we would like to add a verified label to this issue if it got fixed for you? Thanks

@voltflake
Copy link
Author

Yes, works fine for me. Thanks!

@isidorn
Copy link
Contributor

isidorn commented Mar 25, 2020

Great, thanks for letting us know. Adding verified label,

@isidorn isidorn added the verified Verification succeeded label Mar 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@weinand @isidorn @voltflake