Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace underline in Parameter Hints with color #92297

Closed
vwkd opened this issue Mar 9, 2020 · 6 comments
Closed

Replace underline in Parameter Hints with color #92297

vwkd opened this issue Mar 9, 2020 · 6 comments
Assignees
@miguelsolorio
Labels
editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2021

Comments

@vwkd
Copy link

vwkd commented Mar 9, 2020 •
edited

I find the Parameter Hints in VS Code very hard to read in comparison to IntelliJ.

The main distraction is the underbar which hinders the read flow. The underbar distracts the pattern recognition of your eyes and makes it hard to read whatever is above it. There are whole studies on the topic of underbars and readability, see for example uxbooth.com.

You don't need to read a paper to come to the conclusion that reading text with an underbar is bad.

See for yourself how much easier it is without because you can read that much faster.

Instead of an underbar below the current parameter, using a color would be a much better choice. I personally like a bold orange color like in Webstorm, but would already be happy if just the underbar were gone. Please, reconsider this design choice.

VS Code

vscode

vscodelong

Webstorm

webstorm

wish
@octref octref added editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality labels Mar 9, 2020
@octref
Copy link
Contributor

octref commented Mar 9, 2020

@misolori Makes sense to me, what do you think?

@octref octref added this to the Backlog milestone Mar 9, 2020
@miguelsolorio
Copy link
Contributor

I'd be up to try this, we could either use the blue highlight we use for fuzzy search:

image

Or make the default text a shade of the foreground and make the highlight brighter:

image

We can show this in the ux channel to get feedback

@vwkd
Copy link
Author

vwkd commented Mar 9, 2020 •
edited

Wow, I think the second one looks really good! The bright white highlight points directly to the relevant information and the shaded text doesn't distract anymore. I have to change my mind about color and vote for simple bold white.

Btw. You guys are awesome for responding that fast and thanks for trying this change out!

@KamasamaK
Copy link

I think using color for this purpose would basically prevent #55044

@octref
Copy link
Contributor

octref commented Mar 10, 2020

I would say adding a theme color.
@KamasamaK Yourn concern is valid. @misolori can we also try using a highlight overlay on top of current parameter, and source the color from editor selection background?

image

@Tyriar Tyriar assigned Tyriar and unassigned octref Aug 26, 2020
@Tyriar Tyriar mentioned this issue Oct 11, 2021
Open
@Tyriar Tyriar changed the title Replace underbar in Parameter Hints with color Replace underline in Parameter Hints with color Oct 11, 2021
@Tyriar Tyriar assigned Tyriar and unassigned Tyriar Oct 11, 2021
@miguelsolorio
Copy link
Contributor

Let's go with the highlight color and see how it feels. If it's too strong we can default back to a less prominent color. You can also theme this via editorHoverWidget.highlightForeground.

Dark

Light

CleanShot 2021-10-19 at 06 26 49@2x

CleanShot 2021-10-19 at 06 27 47@2x

CleanShot 2021-10-19 at 06 28 30@2x

@miguelsolorio miguelsolorio modified the milestones: Backlog, October 2021 Oct 19, 2021
@miguelsolorio miguelsolorio added themes Color theme issues verification-needed Verification of issue is requested labels Oct 19, 2021
@Tyriar Tyriar removed their assignment Oct 25, 2021
@jrieken jrieken added the verified Verification succeeded label Oct 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
7 participants
@jrieken @Tyriar @octref @KamasamaK @vwkd @miguelsolorio and others