Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] Trying to set local JSON Schema file, generates empty files while typing the filename #92300

Closed
ajdvoynos opened this issue Mar 9, 2020 · 4 comments
Closed

[json] Trying to set local JSON Schema file, generates empty files while typing the filename #92300

ajdvoynos opened this issue Mar 9, 2020 · 4 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Milestone
March 2020

Comments

@ajdvoynos
Copy link

ajdvoynos commented Mar 9, 2020 •
edited

Issue Type: Bug

  1. Open new tab
  2. Set language to JSON
  3. Create an empty json object
  4. Start typing a "$schema" property that points to a local schema file (in the same folder for example)

Expected: No other tabs are created while typing
Actual: VSCode starts creating new tabs with the partial filename that I'm writing.

For example, if I try to set the schema to "./schema.json" it would create 11 new tabs(one for each letter I typed after the ./"

image

VS Code version: Code 1.42.1 (c47d83b, 2020-02-11T14:45:59.656Z)
OS version: Windows_NT x64 10.0.18362

System Info
Item Value
CPUs AMD Ryzen 7 2700 Eight-Core Processor (16 x 3394)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.92GB (5.37GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (8)
Extension Author (truncated) Version
prettify-json moh 0.0.3
vscode-azurefunctions ms- 0.21.0
csharp ms- 1.21.13
remote-wsl ms- 0.42.3
azure-account ms- 0.8.8
vsliveshare ms- 1.0.1711
vscode-json-path wei 2.3.1
markdown-pdf yza 1.4.2
@aeschli aeschli changed the title Trying to set local JSON Schema file, generates empty files while typing the filename [json] Trying to set local JSON Schema file, generates empty files while typing the filename Mar 11, 2020
@aeschli aeschli added json JSON support issues bug Issue identified by VS Code Team member as probable bug labels Mar 11, 2020
@aeschli aeschli added this to the March 2020 milestone Mar 11, 2020
@mjbvz mjbvz added the verified Verification succeeded label Apr 3, 2020
@ajdvoynos
Copy link
Author

@aeschli That was a really fast fix, thanks! Unfortunately, there's still something weird happening. It seems like Code is still trying to open the tabs, but it's hiding them or something?

At first the only indication is in the Explorer view (notice 4 unsaved elements when I don't have any open unsaved documents):
image

But if you close Code and open the workspace again, it opens all the tabs again:
image

This happens to me every time I reopen the workspace where I'm working with the json schema.

Let me know if you need more info. Thanks!

@ajdvoynos
Copy link
Author

I'm having a hard time reproducing this consistently. The only consistent behavior I'm seeing is when you reopen the workspace it tries to open the tabs.

The real strange thing though, is that even after renaming the $schema to something else, it still tries to open the old schema file, which is not referenced anywhere anymore, so that leads me to believe it may be a bug tied specifically to workspaces? It's still somewhere holding a reference to those files?

@aeschli
Copy link
Contributor

aeschli commented Apr 8, 2020

@ajdvoynos no worries, we understand the issue and a fix has been pushed a while ago to insiders. You can try things there. Or wait for stable (1.44) which will come out these days.

@ajdvoynos
Copy link
Author

Oh my bad! I thought the issue was resolved in 1.43 which is the one I was using. I just tried it out in 1.44 and I'm not seeing any issues anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug json JSON support issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@ajdvoynos @aeschli @mjbvz