Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk File Service "after each" hook for "readFile - FILE_TOO_LARGE - streamed" #92334

Closed
isidorn opened this issue Mar 10, 2020 · 1 comment
Closed

Disk File Service "after each" hook for "readFile - FILE_TOO_LARGE - streamed" #92334

isidorn opened this issue Mar 10, 2020 · 1 comment
Assignees
@bpasero
Milestone
March 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 10, 2020

Electron unit test failure here https://dev.azure.com/vscode/VSCode/_build/results?buildId=39020&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=08e986c2-058e-5f01-51da-ae4278e2d74e
@bpasero
Copy link
Member

bpasero commented Mar 10, 2020

I added a larger timeout of 10s vs 5s and want to monitor if this helps. As last resort, I can disable this test for operating systems that have a bad file system implementation (Windows).

@bpasero bpasero added this to the March 2020 milestone Mar 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @isidorn