Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly report if external terminal isn't available #92380

Closed
weinand opened this issue Mar 10, 2020 · 2 comments
Closed

Properly report if external terminal isn't available #92380

weinand opened this issue Mar 10, 2020 · 2 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
March 2020

Comments

@weinand
Copy link
Contributor

weinand commented Mar 10, 2020 •
edited

  • create a launch config for a debug type that supports configuration of an "external terminal", e.g. "node".
  • enable "external terminal" in that launch config
  • set external terminal to some invalid application, e.g. 
    "terminal.external.osxExec": "foobar"
  • start debugging

Observe:
no error is reported and a debug session does not start
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 10, 2020
@weinand weinand added this to the March 2020 milestone Mar 10, 2020
@weinand weinand self-assigned this Mar 10, 2020
@weinand weinand mentioned this issue Mar 10, 2020
Closed
@weinand
Copy link
Contributor Author

weinand commented Mar 11, 2020

With the fix an error alert is shown:

2020-03-11_12-25-59

@weinand
Copy link
Contributor Author

weinand commented Apr 2, 2020

Verification steps: see initial comment

@connor4312 connor4312 added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@weinand @connor4312